Re: [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback

From: Wolfram Sang
Date: Tue Mar 01 2016 - 15:30:39 EST


On Thu, Feb 18, 2016 at 05:53:13PM +0200, Daniel Baluta wrote:
> From: Adriana Reus <adriana.reus@xxxxxxxxx>
>
> Add a check in i2c_mux_master_xfer before calling the select callback.
> This is necessary so that NULL callbacks can be safely registered.
>
> Signed-off-by: Adriana Reus <adriana.reus@xxxxxxxxx>
> Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxxxx>

Hmm, rather than supporting that in the core, I'd prefer to have the
driver pass an empty function instead. Then, in the driver, we can have
a comment explaining the special situation.

Attachment: signature.asc
Description: PGP signature