Re: [PATCH] eata: Convert eata driver as normal PCI and platform device drivers

From: Arthur Marsh
Date: Tue Mar 01 2016 - 16:36:50 EST




Arthur Marsh wrote on 02/03/16 03:57:


Christoph Hellwig wrote on 01/03/16 17:22:
Hi Jiang.

I'd love to see this patch in and abuse of the old PCI API gone.

Did you resolve the problems Arthur saw with the previous iteratons
of the patch?


I applied Jiang Liu's patch of 1st March 2016 to a clean kernel
4.5.0-rc6 source, removed my workaround of removing and re-adding the
eata module before mounting file-systems that are on disks attached to
the DPT SCSI card using the eata driver, and was able to kexec from the
new kernel successfully.

Arthur.

I spoke too soon, without removing and re-inserting the eata module before any filesystems on disks attached to the DPT controller were mounted, I'd get the following messages, similar to ones previously reported:

sd 0:0:6:0: tag#0 abort, mbox 1.
EATA0: abort, mbox 1 is in use.
sd 0:0:6:0: tag#0 reset, enter.
EATA0: reset, mbox 1 in reset.
EATA0: reset, board reset done, enabling interrupts.
EATA0: reset, interrupts disabled, loops 100415.
EATA0, reset, mbox 1 locked, DID_RESET, done.
EATA0: reset, exit, done.


and so on, finally hanging after printing "kexec_core: Starting new kernel" (I have a photo of the messages if they're needed).

So I'm still using the new patch but have to continue to remove and reinsert eata at start-up before any attempts to mount disks attatched to the DPT SCSI controller.

Arthur.