Re: [PATCH] staging/lustre: Unbreak ll_prep_inode iget result check

From: Greg KH
Date: Wed Mar 02 2016 - 18:21:50 EST


On Wed, Mar 02, 2016 at 08:25:39AM -0500, green@xxxxxxxxxxxxxx wrote:
> From: Oleg Drokin <green@xxxxxxxxxxxxxx>
>
> commit 020ecc6f3229 ("staging: lustre: llite: Remove IS_ERR tests")
> managed to break one of the converted checks by losing a dereference
> causing the condition to be wrong and hence leading
> to a crash later on in case of actual error.
> IS_ERR_OR_NULL(*inode) got converted into !inode.
>
> Signed-off-by: Oleg Drokin <green@xxxxxxxxxxxxxx>
> CC: Amitoj Kaur Chawla <amitoj1606@xxxxxxxxx>
> ---
> I am not sure where did that patch came from as I cannot see
> it in either my inbox or in any public mailinglists via google.

My fault, it is part of the Outreachy application process, I missed that
bug, sorry about this.

greg k-h