Re: [PATCH v2 3/6] rockchip: power-domain: add support for sub-power domains
From: Kevin Hilman
Date: Wed Mar 02 2016 - 19:05:24 EST
On Thu, Feb 18, 2016 at 4:20 PM, Heiko Stuebner <heiko@xxxxxxxxx> wrote:
> In general the code looks like you're going to group the domains
> hirarchically, like
>
> power: power-controller {
> compatible = "rockchip,rk3399-power-controller";
>
> pd_cci {
> reg = <RK3399_PD_CCI>;
> clocks = ...;
>
> pd_cci0 {
> reg = <RK3399_PD_CCI0>;
> clocks = ...;
> };
> };
> };
>
> This isn't documented in the dt-binding and also isn't really improving
> reading these declarations. Instead as I said before, I think I'd like more
> get inspiration from how Exynos is doing that already
Heiko and I had a chat offline about this, and I mentioned that the
Exynos way is not the preferred way. The nesting that is being done
here (and in v4) is the better way, and is fully supported by the
genpd code.
Kevin