Re: [PATCH 1/2] phy: rcar-gen2: add fallback binding
From: Simon Horman
Date: Wed Mar 02 2016 - 19:13:28 EST
On Wed, Mar 02, 2016 at 10:37:31AM +0100, Geert Uytterhoeven wrote:
> On Wed, Mar 2, 2016 at 3:37 AM, Simon Horman <horms+renesas@xxxxxxxxxxxx> wrote:
> > In the case of Renesas R-Car hardware we know that there are generations of
> > SoCs, e.g. Gen 2 and Gen 3. But beyond that its not clear what the
> > relationship between IP blocks might be. For example, I believe that
> > r8a7790 is older than r8a7791 but that doesn't imply that the latter is a
> > descendant of the former or vice versa.
> >
> > We can, however, by examining the documentation and behaviour of the
> > hardware at run-time observe that the current driver implementation appears
> > to be compatible with the IP blocks on SoCs within a given generation.
> >
> > For the above reasons and convenience when enabling new SoCs a
> > per-generation fallback compatibility string scheme being adopted for
> > drivers for Renesas SoCs.
> >
> > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
>
> > --- a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt
> > +++ b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt
> > @@ -7,6 +7,12 @@ Required properties:
> > - compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC.
> > "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC.
> > "renesas,usb-phy-r8a7794" if the device is a part of R8A7794 SoC.
> > + "renesas,usb-phy-gen2" for a generic R-Car Gen2 compatible device.
>
> "renesas,rcar-gen2-usb-phy"?
I seem to always get these backwards first go :(
I'll update this and the following patch as you suggest.