Re: [PATCH V3 2/4] net-next: mediatek: add support for MT7623 ethernet

From: Joe Perches
Date: Thu Mar 03 2016 - 16:07:07 EST


On Thu, 2016-03-03 at 21:02 +0100, John Crispin wrote:
> Add ethernet support for MediaTek SoCs from the MT7623 family.
[]
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h
[]
> +/* ugly macro hack to make sure hw_stats and ethtool strings are consistent */

I agree and think the _FE macros defines and uses should be removed.