Re: [PATCH] leds: Add Chrome OS keyboard backlight LEDs driver

[Jacek Anaszewski]

Hi Evan,

On 03/04/2016 09:38 AM, Evan McClain wrote:
> On Thu, 2016-03-03 at 15:46 -0800, Dmitry Torokhov wrote:
> > From: Simon Que <sque@xxxxxxxxxxxx>
> >
> > This is a driver for ACPI-based keyboard backlight LEDs found on
> > Chromebooks. The driver locates \\_SB.KBLT ACPI device and exports
> > backlight as "chromeos::kbd_backlight" LED class device in sysfs.
>
> Was it ever decided where this driver should live? I was planning on
> submitting to platform/chrome since most keyboard backlights seem to
> live over there but I don't think I got a response.

It hasn't been decided yet. I can take it, but could you submit one more
version, without

'owner	= THIS_MODULE' in struct platform_driver keyboard_led_driver ?

It is redundant, because the core will do it.

Also the line with devm_kzalloc has over 80 characters.

--
Best regards,
Jacek Anaszewski