Re: [PATCH 5/6] watchdog: atlas7_wdt: test clock rate to avoid division by 0

[Wim Van Sebroeck]

Hi Wolfram,

> From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> 
> The clk API may return 0 on clk_get_rate, so we should check the result before
> using it as a divisor.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
> Should go individually via subsystem tree.
> 
>  drivers/watchdog/atlas7_wdt.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/watchdog/atlas7_wdt.c b/drivers/watchdog/atlas7_wdt.c
> index df6d9242a31958..ed80734befae16 100644
> --- a/drivers/watchdog/atlas7_wdt.c
> +++ b/drivers/watchdog/atlas7_wdt.c
> @@ -154,6 +154,11 @@ static int atlas7_wdt_probe(struct platform_device *pdev)
>  	writel(0, wdt->base + ATLAS7_WDT_CNT_CTRL);
>  
>  	wdt->tick_rate = clk_get_rate(clk);
> +	if (!wdt->tick_rate) {
> +		ret = -EINVAL;
> +		goto err1;
> +	}
> +
>  	wdt->clk = clk;
>  	atlas7_wdd.min_timeout = 1;
>  	atlas7_wdd.max_timeout = UINT_MAX / wdt->tick_rate;
> -- 
> 2.7.0
> 

Patch has been added to linux-watchdog-next.

Kind regards,
Wim.