Re: [PATCH] klp: remove superfluous errors in asm/livepatch.h

[Jiri Kosina]

On Fri, 4 Mar 2016, Josh Poimboeuf wrote:

> > There is an #error in asm/livepatch.h for both x86 and s390 in
> > !CONFIG_LIVEPATCH cases. It does not make much sense as pointed out by
> > Michael Ellerman. One can happily include asm/livepatch.h with
> > CONFIG_LIVEPATCH. Remove it as useless.
> > 
> > Suggested-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> > Signed-off-by: Miroslav Benes <mbenes@xxxxxxx>
> 
> Looks fine to me.  

Thanks. I consider this to be your Ack then :) (if you disagree, please 
shout loudly).

> While we're at it, do we even need the '#ifdef CONFIG_LIVEPATCH' in 
> these files?  And in include/linux/livepatch.h?

You are right, this seems indeed completely unnecessary. I'll remove it 
for 4.6 as well, if noone has any objections.

-- 
Jiri Kosina
SUSE Labs