Re: perf, tools: Refactor and support interval and CSV metrics

From: Jiri Olsa
Date: Mon Mar 07 2016 - 13:48:53 EST


On Mon, Mar 07, 2016 at 07:22:27PM +0100, Andi Kleen wrote:
> On Mon, Mar 07, 2016 at 11:08:42AM +0100, Jiri Olsa wrote:
> > On Thu, Mar 03, 2016 at 03:57:31PM -0800, Andi Kleen wrote:
> >
> > SNIP
> >
> > >
> > > % perf stat -x, --metric-only -a -I 1000
> > > 1.001381652,frontend cycles idle,insn per cycle,stalled cycles per insn,branch-misses of all branches,
> > > 1.001381652,173.32,0.83,2.09,1.73,
> > > 2.002073343,199.47,1.07,1.60,2.14,
> > > 3.002875524,109.52,0.22,7.83,1.63,
> > > 4.003970059,132.10,0.17,10.85,1.51,
> > > 5.004818754,181.60,0.22,8.87,2.22,
> > >
> > >
> > > Available in
> > > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6 perf/stat-metrics-21
> >
> > this branch contains old version of:
> > perf, tools, stat: Add --metric-only support for -A
>
> Old in what way? Looks correct to me.
>
>
> commit e26ba80593023c24c8276ad9853acd7e56ca92ed
> Author: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> Date: Sat Dec 19 11:22:55 2015 -0800
>
> perf, tools, stat: Add --metric-only support for -A
>
> Add metric only support for -A too. This requires a new print
> function that prints the metrics in the right order.
>
> v2: Fix manpage
> v3: Simplify nrcpus computation
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

I did not see the change for print_no_aggr_metric function
in commit:
perf, tools, stat: Add --metric-only support for -A

which I saw in the email..

however now im confused, I did not noticed I had a wrong tree,
however git can't resolve the git tree you mentioned:

> Available in
> git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6 perf/stat-metrics-21

[jolsa@krava perf]$ git remote add ak1 git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6
[jolsa@krava perf]$ git remote update ak1
Fetching ak1
fatal: remote error: access denied or repository not exported: /pub/scm/linux/kernel/git/ak/linux-misc-2.6
error: Could not fetch ak1

so I guess the one I have is the correct one:
git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc

however:
[jolsa@krava perf]$ git remote update ak
Fetching ak
[jolsa@krava perf]$ git branch -r | grep stat-metrics-21
[jolsa@krava perf]$

jirka