Re: [PATCH v6 0/4] powercap/rapl: reduce ipi calls and misc clean up

From: Thomas Gleixner
Date: Tue Mar 08 2016 - 02:59:38 EST


On Mon, 7 Mar 2016, Jacob Pan wrote:

> On Wed, 24 Feb 2016 13:31:34 -0800
> Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx> wrote:
>
> > Changes since v5:
> > - Split changes into seprate patches. No code change.
> > Changes since V4:
> > - Deleted unnecessary cpumask_any_and() call, assign first
> > cpu as lead Changes since V3:
> > - Avoid for_each_online_cpu() search for per package MSR
> > access. This is achieved by tracking a per package lead cpu via
> > cpumask_xx() calls. (suggested by Thomas Gleixner
> > <tglx@xxxxxxxxxxxxx>)
> > - Add direct reference of RAPL package for each RAPL
> > domain.
> >
> > Jacob Pan (4):
> > cpumask: export cpumask_any_but
> > powercap/rapl: reduce ipi calls
> > powercap/rapl: add package reference per domain
> > powercap/rapl: track lead cpu per package
> >
> > drivers/powercap/intel_rapl.c | 220
> > ++++++++++++++++++++++--------------------
> > lib/cpumask.c | 1 + 2 files changed, 115
> > insertions(+), 106 deletions(-)
> >
> Hi Thomas,
>
> Do you have more comments?

No. Looks reasonable now.