Re: [PATCH v2 0/9] cleanup around kvm_sync_page, and a few micro-optimizations

From: Takuya Yoshikawa
Date: Tue Mar 08 2016 - 03:34:27 EST


On 2016/03/08 17:30, Paolo Bonzini wrote:
> On 08/03/2016 09:00, Takuya Yoshikawa wrote:
>>> KVM: MMU: introduce kvm_mmu_flush_or_zap
>>> KVM: MMU: move TLB flush out of __kvm_sync_page
>>> KVM: MMU: use kvm_sync_page in kvm_sync_pages
>>> KVM: MMU: cleanup __kvm_sync_page and its callers
>>> KVM: MMU: invert return value of mmu.sync_page and *kvm_sync_page*
>>> KVM: MMU: move zap/flush to kvm_mmu_get_page
>>> KVM: MMU: coalesce more page zapping in mmu_sync_children
>>
>> 1-7 look good to me.
>
> Great, these are the ones where I wanted more review.
>
> Can I add your Reviewed-by for these?

Yes, please.

Reviewed-by: Takuya Yoshikawa <yoshikawa_takuya_b1@xxxxxxxxxxxxx>

Takuya