Re: [PATCH 5/8] drivers/pinctrl: make stm32/pinctrl-stm32f429.c explicitly non-modular
From: Linus Walleij
Date: Tue Mar 08 2016 - 22:26:10 EST
On Tue, Mar 1, 2016 at 3:48 AM, Paul Gortmaker
> The Kconfig currently controlling compilation of this code is:
> drivers/pinctrl/stm32/Kconfig:config PINCTRL_STM32F429
> drivers/pinctrl/stm32/Kconfig: bool "STMicroelectronics STM32F429 pin control" if COMPILE_TEST && !MACH_STM32F429
> ...meaning that it currently is not being built as a module by anyone.
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
> Cc: Patrice Chotard <patrice.chotard@xxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
Patch applied with Maxime's ACK.