Re: [PATCH] pinctrl: pxa2xx: export symbols

From: Uwe Kleine-König
Date: Wed Mar 09 2016 - 03:32:26 EST


On Wed, Mar 09, 2016 at 09:11:49AM +0700, Linus Walleij wrote:
> The pxa2xxx fails some automated builds because of unexported
> symbols.
>
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

There is 3a5242e648a8d009f0e0fd47867592e5265374b6 in linus/master which
does a part of this patch already.

Apart from that I don't understand the patch. The only user of
pxa2xx_pinctrl_init is drivers/pinctrl/pxa/pinctrl-pxa27x.c[1] and this
is built into the same module as pinctrl-pxa2xx.o. So without testing I
wonder in which configuration this fails to build.

Best regards
Uwe

[1] git grep -E pxa2xx_pinctrl_\(in\|ex\)it next/master
git grep -E pxa2xx_pinctrl_\(in\|ex\)it linus/master

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |