Re: [PATCH 2/4] infiniband: hns: add Hisilicon RoCE support(binding)

[oulijun]

Hi Sergei Shtylyov, thanks for reviewing
I have modified the binding referred to your advice and the bindings of other module.
I will send a new patch in future.

Thanks
Lijun Ou

On 2016/3/4 21:51, Sergei Shtylyov wrote:
> Hello.
> 
> On 3/4/2016 11:41 AM, Wei Hu(Xavier) wrote:
> 
>> This submit add binding file and dts file.
>>
>> Signed-off-by: Wei Hu(Xavier) <xavier.huwei@xxxxxxxxxx>
>> Signed-off-by: oulijun <oulijun@xxxxxxxxxx>
>> ---
>>   .../bindings/infiniband/hisilicon-hns-roce.txt     | 68 ++++++++++++++++++++++
>>   1 file changed, 68 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
>>
>> diff --git a/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
>> new file mode 100644
>> index 0000000..8004641
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt
>> @@ -0,0 +1,68 @@
>> +HiSilicon RoCE DT description
>> +
>> +HiSilicon RoCE engine is a part of network subsystem.
>> +It works depending on other part of network wubsytem, such as, gmac and
>> +dsa fabric.
>> +
>> +Additional properties are described here:
>> +
>> +Required properties:
>> +- compatible: Should contain "hisilicon,hns-roce-v1".
>> +- reg: Physical base address of the roce driver and
>> +length of memory mapped region.
>> +- eth-handle: phandle, specifies a reference to a node
>> +representing a ethernet device.
>> +- dsaf-handle: phandle, specifies a reference to a node
>> +representing a dsaf device.
>> +- #address-cells: must be 2
>> +- #size-cells: must be 2
>> +Optional properties:
>> +- dma-coherent: Present if DMA operations are coherent.
>> +- interrupt-parent: the interrupt parent of this device.
>> +- interrupts: should contain 32 completion event irq,1 async event irq
>> +and 1 event overflow irq.
> 
>    The "interrupt-names" prop is very desirable for so many interrupts.
> 
>> +Example:
>> +    rocee@0xc4000000 {
> 
>    The node names should be generic and "0x" should be omitted, i.e. "infiniband@c4000000".
> 
> MBR, Sergei
> 
> 
> .
>