Re: [PATCH 2/3] pinctrl: ns2: add pinmux driver support for Broadcom NS2 SoC

From: Ray Jui
Date: Wed Mar 09 2016 - 16:07:56 EST

Hi Linus,

On 3/9/2016 3:04 AM, Linus Walleij wrote:
On Thu, Mar 3, 2016 at 6:41 PM, Yendapally Reddy Dhananjaya Reddy
<yendapally.reddy@xxxxxxxxxxxx> wrote:

This adds the initial support of the Broadcom NS2 pinmux driver

Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@xxxxxxxxxxxx>

Now yet another Broadcom driver!

Can I get the help of the maintainers of the other
Broadcom drivers to say:

- If this looks sane

I've reviewed this driver internally before it was sent out to public. Here's my reviewed-by:

Reviewed-by: Ray Jui <ray.jui@xxxxxxxxxxxx>

Like I mentioned before, we have been working closely with our ASIC team to have one pad per register based register layout in our next-gen SoC. That way we are able to use the generic pinctrl-single driver. It's definitely our best interest to re-use a generic driver when possible, to minimize the ongoing maintenance cost. Note we only have control on chips that we work on; there are other Broadcom SoCs that we do not have a say, unfortunately.

- If this hardware looks suspiciously similar to one of the
other drivers and should rather me a subdriver of one of
the existing ones

The IOMUX block in NS2 seems different from that of Cygnus and NSP. It only supports group based mux configuration and does not have any mechanism to allow GPIO pin function override. It also supports per pad based pinconf functions.

Linus Walleij