Re: [PATCH 1/3] nfit, libnvdimm: clear poison command support

[Verma, Vishal L]

On Tue, 2016-03-08 at 14:47 -0800, Dan Williams wrote:
> Add the boiler-plate for a 'clear error' command based on section
> 9.20.7.6 "Function Index 4 - Clear Uncorrectable Error" from the ACPI
> 6.1 specification, and add a reference implementation in nfit_test.
> 
> Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---
> Âdrivers/acpi/nfit.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ12 +++++++++++-
> Âdrivers/nvdimm/bus.cÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ19 +++++++++++++++++++
> Âinclude/uapi/linux/ndctl.hÂÂÂÂÂÂÂ|ÂÂÂ13 +++++++++++++
> Âtools/testing/nvdimm/test/nfit.c |ÂÂÂ29 +++++++++++++++++++++++++++++
> Â4 files changed, 72 insertions(+), 1 deletion(-)
> 

<snip>

> diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h
> index cc68b92124d4..0f001c571cdd 100644
> --- a/include/uapi/linux/ndctl.h
> +++ b/include/uapi/linux/ndctl.h
> @@ -98,6 +98,14 @@ struct nd_cmd_ars_status {
> Â	} __packed records[0];
> Â} __packed;
> Â
> +struct nd_cmd_clear_error {
> +	__u64 address;
> +	__u64 length;
> +	__u32 status;
> +	__u8 reserved[4];
> +	__u64 cleared;
> +} __packed;
> +
> Âenum {
> Â	ND_CMD_IMPLEMENTED = 0,
> Â
> @@ -105,6 +113,7 @@ enum {
> Â	ND_CMD_ARS_CAP = 1,
> Â	ND_CMD_ARS_START = 2,
> Â	ND_CMD_ARS_STATUS = 3,
> +	ND_CMD_CLEAR_ERROR = 4,
> Â
> Â	/* per-dimm commands */
> Â	ND_CMD_SMART = 1,
> @@ -129,6 +138,7 @@ static inline const char
> *nvdimm_bus_cmd_name(unsigned cmd)
> Â		[ND_CMD_ARS_CAP] = "ars_cap",
> Â		[ND_CMD_ARS_START] = "ars_start",
> Â		[ND_CMD_ARS_STATUS] = "ars_status",
> +		[ND_CMD_CLEAR_ERROR] = "clear_error",
> Â	};
> Â
> Â	if (cmd < ARRAY_SIZE(names) && names[cmd])
> @@ -187,6 +197,9 @@ static inline const char *nvdimm_cmd_name(unsigned
> cmd)
> Â#define ND_IOCTL_ARS_STATUS		_IOWR(ND_IOCTL,
> ND_CMD_ARS_STATUS,\
> Â					struct nd_cmd_ars_status)
> Â
> +#define ND_IOCTL_CLEAR_ERROR		_IOWR(ND_IOCTL,
> ND_CMD_CLEAR_ERROR,\
> +					struct nd_cmd_ars_status)
> +

Typo here? Should be structÂnd_cmd_clear_error.