Re: [PATCH net-next] bpf: avoid copying junk bytes in bpf_get_current_comm()
From: David Miller
Date: Wed Mar 09 2016 - 23:28:22 EST
From: Alexei Starovoitov <ast@xxxxxx>
Date: Wed, 9 Mar 2016 20:02:33 -0800
> Lots of places in the kernel use memcpy(buf, comm, TASK_COMM_LEN); but
> the result is typically passed to print("%s", buf) and extra bytes
> after zero don't cause any harm.
> In bpf the result of bpf_get_current_comm() is used as the part of
> map key and was causing spurious hash map mismatches.
> Use strlcpy() to guarantee zero-terminated string.
> bpf verifier checks that output buffer is zero-initialized,
> so even for short task names the output buffer don't have junk bytes.
> Note it's not a security concern, since kprobe+bpf is root only.
> Fixes: ffeedafbf023 ("bpf: introduce current->pid, tgid, uid, gid, comm accessors")
> Reported-by: Tobias Waldekranz <tobias@xxxxxxxxxxxxxx>
> Signed-off-by: Alexei Starovoitov <ast@xxxxxxxxxx>
> Targeting net-next, since it's too late for net.
> I think it makes sense for stable as well.
Applied and queued up for -stable, thanks.