Re: [PATCH] Revert "[media] au0828: use v4l2_mc_create_media_graph()"

From: Mauro Carvalho Chehab
Date: Thu Mar 10 2016 - 12:53:27 EST

Em Thu, 10 Mar 2016 09:16:30 -0700
Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> escreveu:

> On 03/08/2016 08:26 PM, Shuah Khan wrote:
> > This reverts commit 9822f4173f84cb7c592edb5e1478b7903f69d018.
> > This commit breaks au0828_enable_handler() logic to find the tuner.
> > Audio, Video, and Digital applications are broken and fail to start
> > streaming with tuner busy error even when tuner is free.
> >
> > Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
> > ---
> > drivers/media/usb/au0828/au0828-video.c | 103 ++++++++++++++++++++++++++++++--
> > drivers/media/v4l2-core/v4l2-mc.c | 21 +------
> > 2 files changed, 99 insertions(+), 25 deletions(-)
> >
> Hi Mauro,
> Please pull this revert in as soon as possible. Without
> the revert, auido, video, and digital applications won't
> start even. There is a bug in the common routine introduced
> in the commit 9822f4173f84cb7c592edb5e1478b7903f69d018 which
> causes the link between source and sink to be not found.
> I am testing on WIn-TV HVR 950Q

No, this patch didn't seem to have broken anything. The problems
you're reporting seem to be related, instead, to this patch:

I rebased it on the top of the master tree (without reverting this

Please check if it solved for you.

Yet, I'm seeing several troubles with au0828 after your patch series:

1) when both snd-usb-audio and au0828 are compiled as module and not
blacklisted, I'm getting some errors:

2) removing/reprobing au0828 driver ~3 times, the Kernel becomes
unstable. Probably, some kobj ref were decremented every time a
module insert/removal pair is called from userspace, causing the
kref to reach zero, thus causing the trouble;

3) the media entities that should have been created by
media_snd_stream_init() are never created. Maybe this is related
with (1).

Please check.