Re: [PATCH] net: dsa: Fix cleanup resources upon module removal

From: David Miller
Date: Thu Mar 10 2016 - 16:21:10 EST


From: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
Date: Tue, 8 Mar 2016 10:36:20 +0100

> The initial commit badly merged into the dsa_resume method instead
> of the dsa_remove_dst method.
> As consequence, the dst->master_netdev->dsa_ptr is not set to NULL on
> removal and re-bind of the dsa device fails with error -17.
>
> Fixes: b0dc635d923c ("net: dsa: cleanup resources upon module removal ")
> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> ---
> net/dsa/dsa.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> David, Florian, Andrew,
>
> This fix is quite urgent since it breaks all the removal cleanup.

Since 'net' is closed, I've applied this to 'net-next' and queue it up for
-stable.

Thanks.