Re: [Xen-devel] [PATCH] xen/events/fifo: Add missing hotplug notifier transition

[Anna-Maria Gleixner]

On Fri, 11 Mar 2016, David Vrabel wrote:

> On 11/03/16 09:00, Anna-Maria Gleixner wrote:
> > The evtchn_fifo_cpu_notification() hotplug callback lacks handling of
> > the CPU_UP_CANCELED case. That means, if CPU_UP_PREPARE fails, the
> > handle of the fifo events is not dropped.
> > 
> > Add handling for CPU_UP_CANCELED transition to drop the fifo events
> > handle.
> 
> __evtchn_fifo_handle_events() does not releases resources, it processes
> any pending events for this CPU.
> 
> This patch would only be necessary if a CPU in CPU_UP_CANCELED state may
> have had unmasked interrupts.  If so you would need:

Thanks for the explanation

> case CPU_UP_CANCELED:
>           if (per_cpu(cpu_control_block, cpu))
>               __evtchn_fifo_handle_events(cpu, true);
>           break;
> 
> To handle the case where the control block allocation or initialization
> failed during CPU_UP_PREPARE.

This would not be necessary, because if the CPU_UP_PREPARE of this
notifier fails, the CPU_UP_CANCELLED of this notifier will not be
invoked.

Anna-Maria