Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code.

From: David Daney
Date: Fri Mar 11 2016 - 12:41:19 EST

On 03/11/2016 09:31 AM, Andrew Lunn wrote:
+ phy_np = of_parse_phandle(node, "phy-handle", 0);
+ /* If there is no phy or defective firmware presents
+ * this cortina phy, for which there is no driver
+ * support, ignore it.
+ */
+ if (phy_np &&
+ !of_device_is_compatible(phy_np, "cortina,cs4223-slice")) {

Hi David

What is a cortina,cs4223-slice,

It is 1/4 of:

and why does it need to be handled differently?

$ ls drivers/net/phy/*cortina*
ls: cannot access drivers/net/phy/*cortina*: No such file or directory

For this configuration of thunder_bgx.c, the use of a Linux PHY driver is optional.

The firmware should probably not specify a PHY here, but it does so we ignore it so we don't wait around forever for the non-existent driver to bind.