Re: [PATCH] staging: rtl8712: added few code enhancements in rtl8712_led.c

[Larry Finger]

On 03/09/2016 03:54 PM, Claudiu Beznea wrote:
> This patch tries to improve a part of the code from
> rtl8712_led.c by removing duplicates condition checks.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxx>
> ---
>   drivers/staging/rtl8712/rtl8712_led.c | 31 +++++++++++++++----------------
>   1 file changed, 15 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_led.c b/drivers/staging/rtl8712/rtl8712_led.c
> index 9055827..aea6f2d 100644
> --- a/drivers/staging/rtl8712/rtl8712_led.c
> +++ b/drivers/staging/rtl8712/rtl8712_led.c
> @@ -221,11 +221,9 @@ static void SwLedBlink(struct LED_871x *pLed)
>   		break;
>   	case LED_BLINK_StartToBlink:
>   		if (check_fwstate(pmlmepriv, _FW_LINKED) &&
> -		    (pmlmepriv->fw_state & WIFI_STATION_STATE))
> -			bStopBlinking = true;
> -		if (check_fwstate(pmlmepriv, _FW_LINKED) &&
> -		    ((pmlmepriv->fw_state & WIFI_ADHOC_STATE) ||
> -		    (pmlmepriv->fw_state & WIFI_ADHOC_MASTER_STATE)))
> +			((pmlmepriv->fw_state & WIFI_STATION_STATE) ||
> +			 (pmlmepriv->fw_state & WIFI_ADHOC_STATE)	||
> +			 (pmlmepriv->fw_state & WIFI_ADHOC_MASTER_STATE)))

The above hunk messes up the alignment of the if statement. Observe the 
alignment of the stuff you are removing. It is correct.


Other than the alignment above, the rest of the patch is correct.

Larry