Re: [PATCH 2/2] isdn: hisax: isac: fixed code style issues.

[Joe Perches]

On Sun, 2016-03-13 at 21:21 +0200, Cosmin-Gabriel Samoila wrote:
> Fixed errors and warnings reported by checkpatch.pl.

Generally it's better to send multiple patches that each
change a specific type of style defect.

As is, this patch changes object code.
Fixing style inconsistency should not do that.

> diff --git a/drivers/isdn/hisax/isac.c b/drivers/isdn/hisax/isac.c
[]
> @@ -24,9 +24,8 @@
>  #define DBUSY_TIMER_VALUE 80
>  #define ARCOFI_USE 1
>  
> -static char *ISACVer[] =
> -{"2086/2186 V1.1", "2085 B1", "2085 B2",
> - "2085 V2.3"};
> +static char *ISACVer[] = {"2086/2186 V1.1", "2085 B1", "2085 B2",
> +"2085 V2.3"};

Most common kernel style would use:

static const char *ISACVer[] = {
	"2086/2186 V1.1", "2085 B1", "2085 B2", "2085 V2.3"
};

> @@ -251,11 +252,12 @@ isac_interrupt(struct IsdnCardState *cs, u_char val)
>  				cs->tx_skb = NULL;
>  			}
>  		}
> -		if ((cs->tx_skb = skb_dequeue(&cs->sq))) {
> +		cs->tx_skb = skb_dequeue(&cs->sq);
> +		if (cs->tx_skb) {
>  			cs->tx_cnt = 0;
>  			isac_fill_fifo(cs);
> -		} else
> -			schedule_event(cs, D_XMTBUFREADY);
> +		}
> +		schedule_event(cs, D_XMTBUFREADY);

This changes object code.