Re: [PATCH 12/22] sun3_scsi: Adopt NCR5380.c core driver

From: Hannes Reinecke
Date: Mon Mar 14 2016 - 03:41:07 EST


On 03/14/2016 05:27 AM, Finn Thain wrote:
> Add support for the custom Sun 3 DMA logic to the NCR5380.c core driver.
> This code is copied from atari_NCR5380.c.
>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
>
> ---
>
> The Sun 3 DMA code is still configured by macros. I have simplified things
> slightly but I have avoided more ambitious refactoring. It's not clear to
> me what that should look like and I can't test sun3_scsi anyway. At least
> this permits the removal of atari_NCR5380.c.
>
> ---
> drivers/scsi/NCR5380.c | 131 +++++++++++++++++++++++++++++++++++++++++++----
> drivers/scsi/sun3_scsi.c | 8 +-
> 2 files changed, 124 insertions(+), 15 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)