Re: [PATCH v2 2/3] block: convert to device_add_disk()

From: Johannes Thumshirn
Date: Mon Mar 14 2016 - 04:15:19 EST


On Fri, Mar 11, 2016 at 07:47:38AM -0800, Dan Williams wrote:
> For block drivers that specify a parent device, convert them to use
> device_add_disk().
>
> This conversion was done with the following semantic patch:
>
> @@
> struct gendisk *disk;
> expression E;
> @@
>
> - disk->driverfs_dev = E;
> ...
> - add_disk(disk);
> + device_add_disk(E, disk);
>
> @@
> struct gendisk *disk;
> expression E1, E2;
> @@
>
> - disk->driverfs_dev = E1;
> ...
> E2 = disk;
> ...
> - add_disk(E2);
> + device_add_disk(E1, E2);
>
> ...plus some manual fixups for a few missed conversions.
>
> Cc: Jens Axboe <axboe@xxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Keith Busch <keith.busch@xxxxxxxxx>
> Cc: Michael S. Tsirkin <mst@xxxxxxxxxx>
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Cc: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>

Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850