Re: [PART1 RFC v2 06/10] svm: Add interrupt injection via AVIC

[Suravee Suthikulpanit]

Hi,

Please ignore this. I should have read the whole thread before reply :(
Sorry for spam.

Suravee

On 03/14/2016 12:25 PM, Suravee Suthikulpanit wrote:
> On 03/07/2016 10:36 PM, Paolo Bonzini wrote:
> > On 04/03/2016 21:46, Suravee Suthikulpanit wrote:
> > > +static void svm_deliver_avic_intr(struct kvm_vcpu *vcpu, int vec)
> > > +{
> > > +    struct vcpu_svm *svm = to_svm(vcpu);
> > > +
> > > +    kvm_lapic_set_vector(vec, avic_get_bk_page_entry(svm, APIC_IRR));
> > > +
> > > +    if (vcpu->mode == IN_GUEST_MODE) {
> > > +        wrmsrl(SVM_AVIC_DOORBELL,
> > > +               __default_cpu_present_to_apicid(vcpu->cpu));
> > > +    } else {
> > > +        kvm_vcpu_kick(vcpu);
> > > +    }
> >
> > You also need to add
> >
> >     kvm_make_request(KVM_REQ_EVENT, vcpu);
> >
> > before the "if", similar to vmx_deliver_posted_interrupt.
> >
> > Paolo
>
> Actually, I should only need that just before the kvm_cpu_kick(vcpu)
> isn't it. I don't think we need it in the case when sending doorbell.
>
> Thanks,
> Suravee