Re: [PATCH] devpts: Make ptmx be owned by the userns owner instead of userns-local 0

[Alexander Larsson]

On sÃn, 2016-03-13 at 22:06 -0700, Andy Lutomirski wrote:
> We used to have ptmx be owned by the inner uid and gid 0.ÂÂChange
> this: if the owner and group are both mapped but are not both 0,
> then use the owner instead.
> 
> For container-style namespaces (LXC, etc), this should have no
> effect -- UID 0 is will either be the owner or will be unmapped.
> 
> The important behavior change is for sandboxes: many sandboxes
> intentionally do not create an inner uid 0.ÂÂWithout this patch,
> mounting devpts in such a sandbox is awkward.ÂÂWith this patch, it
> will just work and ptmx will be owned by the namespace owner.
> 
> Cc: Alexander Larsson <alexl@xxxxxxxxxx>
> Cc: mclasen@xxxxxxxxxx
> Cc: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> Cc: Linux Containers <containers@xxxxxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>

Tested-by: Alexander Larsson <alexl@xxxxxxxxxx>

Seems to work fine for me! Thanks!

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl@xxxxxxxxxx            alexander.larsson@xxxxxxxxx 
He's an uncontrollable voodoo librarian with a robot buddy named Sparky. 
She's a cynical winged journalist from the wrong side of the tracks. They 
fight crime!