Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

From: Suravee Suthikulpanit
Date: Mon Mar 14 2016 - 20:39:58 EST

Hi Peter/Boris/Joerg,

On 3/14/16 23:39, Peter Zijlstra wrote:
On Mon, Mar 14, 2016 at 03:19:45PM +0100, Borislav Petkov wrote:
On Mon, Mar 14, 2016 at 08:37:02PM +0700, Suravee Suthikulpanit wrote:
Basically, we are trying to match the current Perf hierarchy for AMD IOMMU
(arch/x86/events/amd/iommu.c). I can put it into
arch/x86/include/asm/perf_amd_iommu.h. What would you prefer?

Yeah, I was going to say the same thing - match the hierarchy so that
there are no confusions between paths. Makes sense to me.

Well there's still the 'perf' vs' events' thing, but also what other
files did you want to put there?

For now I think I prefer a filename without extra directories; we can
always move files about if there's more use later.

Also, since its being used by both events/amd/iommu.c and
drivers/iommu/amd_iommu.c you can also chose a name in the latter

Actually, I also found that there is currently the include/linux/amd-iommu.h, which contains extern function declarations defined in drivers/iommu/amd_iommu_init.c and drivers/iommu/amd_iommu_v2.c.

What if I just merge the newly introduced arch/x86/include/perf/amd/iommu.h into the include/linux/amd-iommu.h? I do not see the point of having to separate things out into two files.

Joerg, since you were maintaining that file, do you have any objection?