Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling events

From: Steven Rostedt
Date: Tue Mar 15 2016 - 16:06:56 EST


On Wed, 9 Mar 2016 21:46:41 +0100
Jiri Olsa <jolsa@xxxxxxxxxx> wrote:

> Currently we check sample type for ftrace:function event
> even if it's not created as sampling event. That prevents
> creating ftrace_function event in counting mode.
>
> Making sure we check sample types only for sampling events.
>
> Before:
> $ sudo perf stat -e ftrace:function ls
> ...
>
> Performance counter stats for 'ls':
>
> <not supported> ftrace:function
>
> 0.001983662 seconds time elapsed
>
> After:
> $ sudo perf stat -e ftrace:function ls

I'm assuming you gave yourself admin capabilities, and not any normal
user may sample function tracing, right?

-- Steve