Re: [PATCH 3/5] ARM: davinci: da8xx: add cfgchip2 to resources

[Sergei Shtylyov]

Hello.

On 03/16/2016 01:37 AM, David Lechner wrote:

> The usb ohci driver has been change to not include mach/*, so we need
> to pass the cfgchip2 address to the driver so that it can turn the usb
> phy on and off.
>
> Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>
> ---
>   arch/arm/mach-davinci/usb.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/mach-davinci/usb.c b/arch/arm/mach-davinci/usb.c
> index b0a6b52..9607b0c 100644
> --- a/arch/arm/mach-davinci/usb.c
> +++ b/arch/arm/mach-davinci/usb.c
> @@ -148,6 +148,11 @@ static struct resource da8xx_usb11_resources[] = {
>   		.flags	= IORESOURCE_MEM,
>   	},
>   	[1] = {
> +		.start	= DA8XX_SYSCFG0_BASE + DA8XX_CFGCHIP2_REG,
> +		.end	= DA8XX_SYSCFG0_BASE + DA8XX_CFGCHIP2_REG + 4 - 1,
> +		.flags	= IORESOURCE_MEM,
> +	},

   No, this register is shared b/w MUSB and OHCI. The proper thing to do is 
to write the PHY driver and let it control this shared register.

[...]

MBR, Sergei