Re: [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed

From: Laxman Dewangan
Date: Wed Mar 16 2016 - 07:23:57 EST



On Tuesday 15 March 2016 07:42 PM, Linus Walleij wrote:
On Fri, Mar 11, 2016 at 2:43 PM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:

If GPIO hog configuration failed while adding OF based
gpiochip() then return the error instead of ignoring it.

This helps of properly handling the gpio driver dependency.

When adding the gpio hog nodes for NVIDIA's Tegra210 platforms,
the gpio_hogd() fails with EPROBE_DEFER because pinctrl is not
ready at this time and gpio_request() for Tegra GPIO driver
returns error. The error was not causing the Tegra GPIO driver
to fail as the error was getting ignored.

Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
Cc: Benoit Parrot <bparrot@xxxxxx>
Cc: Alexandre Courbot <acourbot@xxxxxxxxxx>
Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Oops is this something I should apply for fixes and tag
for stable?


I dont think that it is needed for stable as this is newly added feature.