Re: [PATCH] gpio: pca953x: Fix pca953x_gpio_set_multiple() on 64-bit

From: Linus Walleij
Date: Wed Mar 16 2016 - 08:03:19 EST


On Fri, Mar 11, 2016 at 5:31 PM, Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:

> pca953x_gpio_set_multiple() divides by 4 to convert from longs to bytes,
> which assumes a 32-bit platform, and is not correct on 64-bit platforms.
> Use "sizeof(...)" instead to fix this.
>
> Fixes: b4818afeacbd8182 ("gpio: pca953x: Add set_multiple to allow multiple bits to be set in one write.")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Patch applied for fixes. Tagged for stable.
Ack from Phil.

Yours,
Linus Walleij