Re: [PATCH 3/5] rtc: rtc-jz4740: Add support for devicetree

[Harvey Hunt]

Hi Alexandre,

On 17/03/16 12:08, Alexandre Belloni wrote:
> On 05/03/2016 at 23:38:49 +0100, Paul Cercueil wrote :
> > Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/rtc/rtc-jz4740.c | 16 +++++++++++++++-
> >   1 file changed, 15 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c
> > index 47617bd..3914b1c 100644
> > --- a/drivers/rtc/rtc-jz4740.c
> > +++ b/drivers/rtc/rtc-jz4740.c
> > @@ -17,6 +17,7 @@
> >   #include <linux/io.h>
> >   #include <linux/kernel.h>
> >   #include <linux/module.h>
> > +#include <linux/of_device.h>
> >   #include <linux/platform_device.h>
> >   #include <linux/rtc.h>
> >   #include <linux/slab.h>
> > @@ -245,6 +246,13 @@ void jz4740_rtc_poweroff(struct device *dev)
> >   }
> >   EXPORT_SYMBOL_GPL(jz4740_rtc_poweroff);
> >
> > +static const struct of_device_id jz4740_rtc_of_match[] = {
> > +	{ .compatible = "ingenic,jz4740-rtc", .data = (void *) ID_JZ4740 },
> > +	{ .compatible = "ingenic,jz4780-rtc", .data = (void *) ID_JZ4780 },
>
> ingenic is not in Documentation/devicetree/bindings/vendor-prefixes.txt,
> you have to add it there before using it.

Ingenic is in vendor-prefixes.txt - it was added by Commit f289cc7 
("devicetree/bindings: add Ingenic Semiconductor vendor prefix").

Thanks,

Harvey