Re: [PATCH] staging: rtl8712: Removed copyright notice

From: Joe Perches
Date: Sun Mar 20 2016 - 05:45:09 EST


On Sun, 2016-03-20 at 03:32 +0000, Parth Sane wrote:
> Removed copyright notice as per checkpatch check warning.

This is not a good patch subject nor commit message.

Removing copyright is a serious thing.
You are not doing that.

You are removing a paragraph about an organization's
address that is subject to change.

Please be more thoughtful about what you are actually
doing when writing your commit subject lines and
messages.


> Signed-off-by: Parth Sane <laerdevstudios@xxxxxxxxx>
>
> ---
>  drivers/staging/rtl8712/drv_types.h | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index 29e47e1..ae79047 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -11,10 +11,6 @@
>   * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
>   * more details.
>   *
> - * You should have received a copy of the GNU General Public License along with
> - * this program; if not, write to the Free Software Foundation, Inc.,
> - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
> - *
>   * Modifications for inclusion into the Linux staging tree are
>   * Copyright(c) 2010 Larry Finger. All rights reserved.
>   *