Re: [RFD] workqueue: WQ_MEM_RECLAIM usage in network drivers

From: Tejun Heo
Date: Sun Mar 20 2016 - 14:55:28 EST


Hello,

On Fri, Mar 18, 2016 at 05:24:05PM -0400, J. Bruce Fields wrote:
> > But does that actually work? It's pointless to add WQ_MEM_RECLAIM to
> > workqueues unless all other things are also guaranteed to make forward
> > progress regardless of memory pressure.
>
> It's supposed to work.
>
> Also note there was a bunch of work done to allow swap on NFS: see
> a564b8f0 "nfs: enable swap on NFS".

Alright, WQ_MEM_RECLAIM for ethernet devices, then.

> I use NFS mounts over wifi at home. I may just be odd. I seem to
> recall some bug reports about suspend vs. NFS--were those also on
> laptops using NFS?
>
> I wonder if home media centers might do writes over wifi to network
> storage?
>
> Googling for "nfs wifi" turns up lots of individuals doing this.
>
> My first impulse is to say that it's probably not perfect but that we
> shouldn't make it worse.

If everything else is working, I'd be happy to throw in WQ_MEM_RECLAIM
but I really don't want to add it if it doesn't actually achieve the
goal. Can a wireless person chime in here?

Thanks.

--
tejun