Re: [PATCH] regulator: Lookup unresolved parent supplies before regulators cleanup

From: Mark Brown
Date: Mon Mar 21 2016 - 07:11:16 EST


On Sun, Mar 20, 2016 at 11:39:46PM -0300, Javier Martinez Canillas wrote:

> Unfortunately, that changed the behavior of the regulator core since now a
> parent supply with a child regulator marked as always-on, won't be enabled
> unless a client driver attempts to get the child regulator during boot.

> This patch makes the unresolved parent supplies to be looked up before the
> regulators late cleanup, so those with a child marked as always on will be
> enabled regardless if a driver attempted to get the child regulator or not.

This doesn't make much sense to me as a fix - it feels like we're doing
a fragile hack. Surely it's better to do this as we register the
devices, that way we're also protected against any similar issues with
this that might occur after late probe if things are built modular? Or
is there a strong reason for doing this only at late_initcall?

Attachment: signature.asc
Description: PGP signature