Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu

From: Yisen Zhuang
Date: Mon Mar 21 2016 - 21:20:47 EST




å 2016/3/21 22:17, Sergei Shtylyov åé:
> Hello.
>
> On 03/21/2016 02:06 PM, Yisen Zhuang wrote:
>
>> From: Kejian Yan <yankejian@xxxxxxxxxx>
>>
>> If mtu for debug port is set more than 1500, it may cause that packets
>> are dropped by ppe. So maximum value for debug port should be 1500.
>>
>> Signed-off-by: Kejian Yan <yankejian@xxxxxxxxxx>
>> Signed-off-by: Yisen Zhuang <Yisen.Zhuang@xxxxxxxxxx>
> [...]
>> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
>> index a69c8af..a68efd6 100644
>> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
>> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
>> @@ -28,6 +28,7 @@ struct dsaf_device;
>> #define MAC_MAX_MTU 9600
>> #define MAC_MAX_MTU_V2 9728
>> #define MAC_MIN_MTU 68
>> +#define MAC_MAX_MTU_DBG MAC_DEFAULT_MTU
>
> Please use tabs, not spaces to indent the value, like above

Will fix it in next version.

Thanks,

Yisen

>
> [...]
>
> MBR, Sergei
>
>
> .
>