Re: [RFC PATCH v1 0/4] Add Rockchip RGA support

From: Yakir Yang
Date: Mon Mar 21 2016 - 22:14:53 EST


Hi Heiko,

On 03/22/2016 08:42 AM, Heiko Stuebner wrote:
Hi Yakir,

Am Montag, 21. März 2016, 20:17:46 schrieb Yakir Yang:
On 03/21/2016 07:29 PM, Heiko Stübner wrote:
Am Montag, 21. März 2016, 17:28:38 schrieb Yakir Yang:
This patch set would add the RGA direct rendering based 2d graphics
acceleration module.
very cool to see that.
;)

This patch set is based on git repository below:
git://people.freedesktop.org/~airlied/linux drm-next
commit id: 568d7c764ae01f3706085ac8f0d8a8ac7e826bd7

And the RGA driver is based on Exynos G2D driver, it only manages the
command lists received from user, so user should make the command list
to data and registers needed by operation to use.

I have prepared an userspace demo application for testing:
https://github.com/yakir-Yang/libdrm-rockchip

That is a rockchip libdrm library, and I have write a simple test case
"rockchip_rga_test" that would test the below RGA features:
- solid
- copy
- rotation
- flip
- window clip
- dithering
Did you submit your libdrm changes as well?

Userspace-interfaces need to be stable so the other side must also get
accepted - even before the kernel change if I remember correctly.
Got it, and I just saw exynos_fimg2d already landed at mainline libdrm.
But I don't find the way to submit patches to libdrm, would you like
share some helps here ;)
Looking at the libdrm sources on cgit.freedesktop.org, I did not find any
specific manual on submitting patches.

But looking at the dri-list archive, dri-devel@xxxxxxxxxxxxxxxxxxxxx is the
right list and looking at the libdrm history it looks like Emil Velikov
<emil.l.velikov@xxxxxxxxx> seems to be doing maintenance-stuff in libdrm.
And as a 3rd recipient, please also include the linux-rockchip list.
Great, thanks, I would improve my libdrm changes, and submit them soon :)

- Yakir
@Emil, please shout if I read that wrong :-)


Hope that helps
Heiko