Re: [PATCH v11] cpufreq: powernv: Add sysfs attributes to show throttle stats

From: Viresh Kumar
Date: Mon Mar 21 2016 - 22:46:36 EST


On 21-03-16, 22:29, Shilpasri G Bhat wrote:
> + create_throttle_sysfs = kcalloc(cpu_nr_cores(), sizeof(bool),
> + GFP_KERNEL);
> + if (!create_throttle_sysfs) {
> + kfree(chips);
> + return -ENOMEM;
> + }
> +
> for (i = 0; i < nr_chips; i++) {
> chips[i].id = chip[i];
> cpumask_copy(&chips[i].mask, cpumask_of_node(chip[i]));
> @@ -582,6 +655,7 @@ static int init_chip_info(void)
>
> static inline void clean_chip_info(void)
> {
> + kfree(create_throttle_sysfs);
> kfree(chips);
> }

Why do you need this at all?. You can use policy->driver data, isn't
it ?

--
viresh