Re: [PATCH v2 5/6] x86/xen,pat: Remove PAT table init code from Xen

[Juergen Gross]

On 22/03/16 18:02, Borislav Petkov wrote:
> On Wed, Mar 16, 2016 at 06:46:58PM -0600, Toshi Kani wrote:
>> Xen supports PAT without MTRR for its guests.  In order to
>> enable WC attribute, it was necessary for xen_start_kernel()
>> to call pat_init_cache_modes() to update PAT table before
>> starting guest kernel.
>>
>> Now that the kernel initializes PAT table to the BIOS handoff
>> state when MTRR is disabled, this Xen-specific PAT init code
>> is no longer necessary.  Delete it from xen_start_kernel().
>>
>> Also change pat_init_cache_modes() to a static function since
>> PAT table should not be tweaked by other modules.
>>
>> Signed-off-by: Toshi Kani <toshi.kani@xxxxxxx>
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>> Cc: Borislav Petkov <bp@xxxxxxx>
>> Cc: Luis R. Rodriguez <mcgrof@xxxxxxxx>
>> Cc: Juergen Gross <jgross@xxxxxxxx>
>> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
>> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
>> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> ---
>>  arch/x86/include/asm/pat.h |    1 -
>>  arch/x86/mm/pat.c          |    2 +-
>>  arch/x86/xen/enlighten.c   |    9 ---------
>>  3 files changed, 1 insertion(+), 11 deletions(-)
> 
> JÃrgen, ack?

Yes, seems to be okay.

Acked-by: Juergen Gross <jgross@xxxxxxxx>


Juergen