Re: [PATCH trace-cmd 1/2] trace-cmd-listen: remove useless printf

From: Peter Xu
Date: Wed Mar 23 2016 - 02:40:16 EST


On Tue, Mar 22, 2016 at 09:18:11AM -0400, Steven Rostedt wrote:
> > diff --git a/trace-listen.c b/trace-listen.c
> > index 1e38eda..12cc9c5 100644
> > --- a/trace-listen.c
> > +++ b/trace-listen.c
> > @@ -721,7 +721,6 @@ static void do_accept_loop(int sfd)
> > do {
> > cfd = accept(sfd, (struct sockaddr *)&peer_addr,
> > &peer_addr_len);
> > - printf("connected!\n");
>
> I probably kept this in for debugging. But I still think there should
> be some kind of logging here. If anything, change this to a debug
> print. I'm working on passing in --debug into the command line here, so
> I'm not going to take this patch. It should be converted to the debug
> coed.

Sure. This is trivial. Please just drop it.

-- peterx