RE: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization

From: Chaitra Basappa
Date: Wed Mar 23 2016 - 05:13:55 EST


Hi,
Please consider this patch as Ack-by: Chaitra P B
<chaitra.basappa@xxxxxxxxxxxx>

Thanks,
Chaitra

-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@xxxxxxxxxx]
Sent: Tuesday, March 22, 2016 6:00 AM
To: Calvin Owens
Cc: Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; James E.J.
Bottomley; Martin K. Petersen; MPT-FusionLinux.pdl@xxxxxxxxxxxx;
linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
kernel-team@xxxxxx; Sreekanth Reddy
Subject: Re: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during
initialization

>>>>> "Calvin" == Calvin Owens <calvinowens@xxxxxx> writes:

Calvin> In _base_make_ioc_operational(), we walk ioc->reply_queue_list
Calvin> and pull a pointer out of successive elements of
Calvin> ioc->reply_post[] for each entry in that list if RDPQ is
Calvin> enabled.

Calvin> Since the code pulls the pointer for the next iteration at the
Calvin> bottom of the loop, it triggers the a KASAN dump on the final
Calvin> iteration:

Broadcom folks, please review.

Thanks!

--
Martin K. Petersen Oracle Linux Engineering