Re: [PATCH 1/5] perf core: Introduce new ioctl options to pause and resume ring buffer
From: Vince Weaver
Date: Wed Mar 23 2016 - 08:42:19 EST
On Wed, 23 Mar 2016, Wangnan (F) wrote:
>
> > Can you also do a patch to the man-pages?
> >
> > http://man7.org/linux/man-pages/man2/perf_event_open.2.html
>
> Sure.
>
> I think I need to provide a patch for:
>
> http://git.kernel.org/cgit/docs/man-pages/man-pages.git
>
> But which one should be the first? Shall we update man pages before
> this patch be merged by upstream? Or Michael and Vince will consider
> this problem?
It is good to see a rough draft of the manpage changes for an ABI
addition like this before the patch gets merged just so we can catch
anything odd about the interface.
Also include (as a comment) the git commit id that introduces the change.
In general manpage patches do not get committed until after the change
hits a full released kernel (as things have been known to get reverted
from -rc kernels in the past).
If you send a rough patch I can fix it up and queue it up with other
manpage patches I have (I'm a bit backlogged but working on catching up).
I'm never quite sure that I get all of the various Signed-off- lines right
for contributed patches though.
Vince