Re: [PATCH v5 2/5] GCC plugin infrastructure
From: Emese Revfy
Date: Wed Mar 23 2016 - 20:10:16 EST
On Fri, 11 Mar 2016 15:25:19 +0900
Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> You sprinkle "gcc-plugins" target in the top Makefile, which I do not like.
>
> Can you descend into scripts/gcc-plugins from scripts/Makefile?
>
>
> subdir-$(CONFIG_MODVERSIONS) += genksyms
> subdir-y += mod
> subdir-$(CONFIG_SECURITY_SELINUX) += selinux
> subdir-$(CONFIG_DTC) += dtc
> subdir-$(CONFIG_GDB_SCRIPTS) += gdb
> +subdir-$(CONFIG_GCC_PLUGINS) += gcc-plugins
>
>
> This is how other host tools do, I think.
Hi,
I tried to remove the gcc-plugins target but sadly in this case the plugins aren't complied.
I don't know if I understand how it should work. I pushed a commit:
https://github.com/ephox-gcc-plugins/gcc-plugins_linux-next/commit/0b005b886bde6c4b9134d01f830d88d464911a65
Could you please help me with what I did wrong?
Thanks
--
Emese