Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

[Xuetao Guan]

> On Mon, Mar 21, 2016 at 07:47:29PM +0800, Xuetao Guan wrote:
>> > unicore32 fails to compile with the following errors.
>> >
>> > mm/memory.c: In function ?ユ?_handle_mm_fault?��:
>> > mm/memory.c:3381: error:
>> > 	too many arguments to function
>> ?ユ?rch_vma_access_permitted?��
>> > mm/gup.c: In function ?ユ?heck_vma_flags?��:
>> > mm/gup.c:456: error:
>> > 	too many arguments to function
>> ?ユ?rch_vma_access_permitted?��
>> > mm/gup.c: In function ?ユΣma_permits_fault?��:
>> > mm/gup.c:640: error:
>> > 	too many arguments to function
>> ?ユ?rch_vma_access_permitted?��
>> >
>> > Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate
>> instruction
>> > fetches")
>> > Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
>> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
>> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>>
>> Thanks.
>>
>> Acked-by: Guan Xuetao <gxt@xxxxxxxxxxxxxxx>
>>
> Who is going to send the patch upstream ?
>
> Guenter

I will do. Thanks.

Xuetao

>
>> > ---
>> >  arch/unicore32/include/asm/mmu_context.h | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/arch/unicore32/include/asm/mmu_context.h
>> > b/arch/unicore32/include/asm/mmu_context.h
>> > index e35632ef23c7..62dfc644c908 100644
>> > --- a/arch/unicore32/include/asm/mmu_context.h
>> > +++ b/arch/unicore32/include/asm/mmu_context.h
>> > @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct
>> mm_struct
>> > *mm,
>> >  }
>> >
>> >  static inline bool arch_vma_access_permitted(struct vm_area_struct
>> *vma,
>> > -		bool write, bool foreign)
>> > +		bool write, bool execute, bool foreign)
>> >  {
>> >  	/* by default, allow everything */
>> >  	return true;
>> > --
>> > 2.5.0
>> >
>>
>