Re: [GIT PULL 00/23] perf/core improvements and fixes

From: Ingo Molnar
Date: Thu Mar 24 2016 - 03:32:29 EST



* Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Hi Ingo,
>
> Please consider pulling, test built on:
>
> [root@jouet ~]# dm
> alldeps-debian: Ok
> alldeps-mageia: Ok
> alldeps-rhel7: Ok
> alldeps-centos: Ok
> alldeps-opensuse: Ok
> alldeps-ubuntu: Ok
> [root@jouet ~]#
>
> All the latest distro releases, updated (dnf/yum/apt-get/urpmi/zypper/etc
> upgraded as of a few days ago) as available on docker.io/vendors.
>
> - Arnaldo
>
> The following changes since commit ced30bc9129777d715057d06fc8dbdfd3b81e94d:
>
> Merge tag 'perf-core-for-mingo-20160310' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-03-11 09:40:25 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160323
>
> for you to fetch changes up to 76267147f233f347dbd8f4f8c05492e5ea0a7dce:
>
> perf llvm: Use strerror_r instead of the thread unsafe strerror one (2016-03-23 17:42:21 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Fix documentation of :ppp modifier in 'perf list' (Andi Kleen)
>
> - Fix silly nodes bitfield bits/bytes length assertion in 'perf bench numa' (Jakub Jelen)
>
> - Remove redundant CPU output in libtraceevent (Steven Rostedt)
>
> - Remove 'core_id' check in topology 'perf test' (Sukadev Bhattiprolu)
>
> Infrastructure:
>
> - Record text offset in dso to calculate objdump address, to use with
> modules in addition to vDSO symbol address calculations (Wang Nan)
>
> - Move utilities.mak from perf to tools/scripts/ (Arnaldo Carvalho de Melo)
>
> - Add cpumode to the perf_sample struct, this way we don't need to pass
> the union event to the machine and thread resolving routines, shortening
> function signatures and allowing the future introduction of a way
> to use tracepoint events instead of the unavailable HW cycles counter on
> powerpc guests in perf kvm by just hooking on perf_evsel__parse_sample,
> at the end (Arnaldo Carvalho de Melo)
>
> - Remove/unexport die() related infrastructure, that at some point will
> finally be removed (Arnaldo Carvalho de Melo)
>
> - Adopt linux/stringify.h from the kernel sources, not to touch this
> kernel header from tools/ (Arnaldo Carvalho de Melo)
>
> - Stop using strbuf for things we can instead trivially use libc's asprintf()
> (Arnaldo Carvalho de Melo)
>
> - Ditch tools/lib/util/abspath.c, its only exported function was used at just
> one place and can be replaced by libc's realpath() (Arnaldo Carvalho de Melo)
>
> - Use strerror_r() in the llvm infrastructure, tread safe, its what is used
> elsewhere in tools/perf/ (Arnaldo Carvalho de Melo)
>
> Cleanups:
>
> - Removed misplaced or needless __maybe_unused/export (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>
> ----------------------------------------------------------------
> Andi Kleen (1):
> perf list: Fix documentation of :ppp
>
> Arnaldo Carvalho de Melo (18):
> tools: Move utilities.mak from perf to tools/scripts/
> perf tools: Remove misplaced __maybe_unused
> perf tests: Forward the perf_sample in the dwarf unwind test
> perf tools: Add cpumode to struct perf_sample
> perf machine: Rename perf_event__preprocess_sample to machine__resolve
> perf thread: Rename perf_event__preprocess_sample_addr to thread__resolve
> perf script: Remove lots of unused arguments
> perf tools: Remove unused DIE_IF macro
> perf tools: Simplify die() mechanism
> perf tools: Remove needless 'extern' from function prototypes
> tools include: Copy linux/stringify.h from the kernel
> perf tools: Do not include stringify.h from the kernel sources
> perf tools: Remove unused perf_pathdup, xstrdup functions
> perf help: Use asprintf instead of adhoc equivalents
> perf probe: No need to use formatting strbuf method
> perf tools: Unexport some methods unused outside strbuf.c
> perf llvm: Use realpath to canonicalize paths
> perf llvm: Use strerror_r instead of the thread unsafe strerror one
>
> Jakub Jelen (1):
> perf bench numa: Fix assertion for nodes bitfield
>
> Steven Rostedt (1):
> tools lib traceevent: Remove redundant CPU output
>
> Sukadev Bhattiprolu (1):
> perf test: Remove 'core_id' check in topo test
>
> Wang Nan (1):
> perf symbols: Record text offset in dso to calculate objdump address
>
> tools/include/linux/stringify.h | 12 +++++
> tools/lib/api/Makefile | 2 +-
> tools/lib/subcmd/Makefile | 2 +-
> tools/lib/traceevent/event-parse.c | 4 +-
> tools/perf/Documentation/Makefile | 2 +-
> tools/perf/Documentation/perf-list.txt | 6 ++-
> tools/perf/Makefile.perf | 2 +-
> tools/perf/arch/powerpc/util/header.c | 4 +-
> tools/perf/bench/bench.h | 22 ++++-----
> tools/perf/bench/mem-memcpy-arch.h | 2 +-
> tools/perf/bench/mem-memset-arch.h | 2 +-
> tools/perf/bench/numa.c | 2 +-
> tools/perf/builtin-annotate.c | 2 +-
> tools/perf/builtin-diff.c | 2 +-
> tools/perf/builtin-help.c | 69 ++++++++++++--------------
> tools/perf/builtin-inject.c | 8 +---
> tools/perf/builtin-mem.c | 2 +-
> tools/perf/builtin-report.c | 3 +-
> tools/perf/builtin-script.c | 46 +++++++-----------
> tools/perf/builtin-timechart.c | 2 +-
> tools/perf/builtin-top.c | 8 ++--
> tools/perf/builtin-trace.c | 9 ++--
> tools/perf/builtin.h | 64 ++++++++++++-------------
> tools/perf/config/Makefile | 2 +-
> tools/perf/tests/code-reading.c | 5 +-
> tools/perf/tests/dwarf-unwind.c | 4 +-
> tools/perf/tests/hists_common.c | 6 ++-
> tools/perf/tests/hists_cumulate.c | 9 +---
> tools/perf/tests/hists_filter.c | 9 +---
> tools/perf/tests/hists_link.c | 20 ++------
> tools/perf/tests/hists_output.c | 9 +---
> tools/perf/ui/gtk/hists.c | 2 +-
> tools/perf/util/Build | 1 -
> tools/perf/util/abspath.c | 37 --------------
> tools/perf/util/annotate.h | 2 +-
> tools/perf/util/auxtrace.h | 2 +-
> tools/perf/util/build-id.c | 3 +-
> tools/perf/util/cache.h | 24 ++++------
> tools/perf/util/callchain.h | 4 +-
> tools/perf/util/cgroup.h | 4 +-
> tools/perf/util/cloexec.h | 2 +-
> tools/perf/util/data-convert-bt.c | 2 +-
> tools/perf/util/db-export.c | 2 +-
> tools/perf/util/dso.h | 3 +-
> tools/perf/util/dwarf-aux.c | 10 ++--
> tools/perf/util/dwarf-aux.h | 72 ++++++++++++++--------------
> tools/perf/util/event.c | 23 ++++-----
> tools/perf/util/event.h | 13 ++---
> tools/perf/util/evsel.c | 1 +
> tools/perf/util/genelf.h | 8 ++--
> tools/perf/util/header.c | 5 --
> tools/perf/util/header.h | 2 +-
> tools/perf/util/hist.c | 2 +-
> tools/perf/util/hist.h | 3 +-
> tools/perf/util/intel-bts.c | 2 +-
> tools/perf/util/jit.h | 12 ++---
> tools/perf/util/llvm-utils.c | 24 ++++++----
> tools/perf/util/llvm-utils.h | 7 ++-
> tools/perf/util/machine.c | 14 +++---
> tools/perf/util/machine.h | 2 +-
> tools/perf/util/parse-events.h | 21 ++++----
> tools/perf/util/path.c | 30 ------------
> tools/perf/util/probe-event.c | 2 +-
> tools/perf/util/probe-event.h | 57 ++++++++++------------
> tools/perf/util/probe-finder.c | 8 ++--
> tools/perf/util/probe-finder.h | 24 +++++-----
> tools/perf/util/quote.h | 2 +-
> tools/perf/util/session.c | 5 +-
> tools/perf/util/sort.c | 2 +-
> tools/perf/util/stat-shadow.c | 18 ++++---
> tools/perf/util/strbuf.c | 9 +++-
> tools/perf/util/strbuf.h | 21 ++++----
> tools/perf/util/svghelper.h | 51 ++++++++++----------
> tools/perf/util/symbol-elf.c | 12 ++---
> tools/perf/util/symbol.h | 4 +-
> tools/perf/util/usage.c | 8 +---
> tools/perf/util/util.h | 27 ++++-------
> tools/perf/util/wrapper.c | 12 -----
> tools/{perf/config => scripts}/utilities.mak | 0
> 79 files changed, 385 insertions(+), 557 deletions(-)
> create mode 100644 tools/include/linux/stringify.h
> delete mode 100644 tools/perf/util/abspath.c
> rename tools/{perf/config => scripts}/utilities.mak (100%)

Pulled, thanks a lot Arnaldo!

Ingo