Re: [PATCH 4/4] arm64: dts: marvell: Rename armada-ap806 XOR nodes

From: Thomas Petazzoni
Date: Thu Mar 24 2016 - 04:17:41 EST


On Wed, 23 Mar 2016 23:24:21 +0100, Andreas FÃrber wrote:
> Node names should not contain an instance number, the unit address
> serves to distinguish nodes of the same name. So rename the XOR nodes
> to just xor@address, using xorX as label instead.
> Fixes: ec7e5a569bce ("arm64: dts: marvell: add Device Tree files for Armada 7K/8K")
> Cc: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Andreas FÃrber <afaerber@xxxxxxx>

Removing the instance number from the node name is obviously good.
However, I don't think it's really needed to add labels. The XOR
engines are purely "internal" devices, so they are always enabled at
the SoC level.

> "marvell,mv-xor-v2" is not yet referenced from any driver in next-20160323.

Yes. The driver has been submitted, but has received some comments that
I need to address.


Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering