Re: [PATCH 1/1] net: macb: remove BUG_ON() and reset the queue to handle RX errors
From: Neil Armstrong
Date: Thu Mar 24 2016 - 10:54:15 EST
On 03/24/2016 03:37 PM, Cyrille Pitchen wrote:
> This patch removes two BUG_ON() used to notify about RX queue corruptions
> on macb (not gem) hardware without actually handling the error.
> The new code skips corrupted frames but still processes faultless frames.
> Then it resets the RX queue before restarting the reception from a clean
> This patch is a rework of an older patch proposed by Neil Armstrong:
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@xxxxxxxxx>
> drivers/net/ethernet/cadence/macb.c | 59 ++++++++++++++++++++++++++++++-------
> 1 file changed, 49 insertions(+), 10 deletions(-)
Thanks for the rework, we solved this situation by moving the descriptors to
an internal RAM with lower latencies, we suspected our AHB-AXI bridge + DDR Controller
to delay the descriptor writes while the interrupt was handled in the meantime.
But the error case was still not handled.
Acked-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>