Re: [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior

[Vlastimil Babka]

On 03/24/2016 04:51 PM, Vlastimil Babka wrote:
> On 03/17/2016 06:40 PM, Lucas Stach wrote:
> > Page isolation has not failed if the fin pfn extends beyond the end pfn
> > and test_pages_isolated checks this correctly. Fix the tracepoint to
> > report the same result as the actual check function.
>
> Right.
>
> > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
>
> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>

Note you didn't have Andrew in To/Cc.

> > ---
> >    include/trace/events/page_isolation.h | 2 +-
> >    1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/trace/events/page_isolation.h b/include/trace/events/page_isolation.h
> > index 6fb644029c80..8738a78e6bf4 100644
> > --- a/include/trace/events/page_isolation.h
> > +++ b/include/trace/events/page_isolation.h
> > @@ -29,7 +29,7 @@ TRACE_EVENT(test_pages_isolated,
> >
> >    	TP_printk("start_pfn=0x%lx end_pfn=0x%lx fin_pfn=0x%lx ret=%s",
> >    		__entry->start_pfn, __entry->end_pfn, __entry->fin_pfn,
> > -		__entry->end_pfn == __entry->fin_pfn ? "success" : "fail")
> > +		__entry->end_pfn <= __entry->fin_pfn ? "success" : "fail")
> >    );
> >
> >    #endif /* _TRACE_PAGE_ISOLATION_H */
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>